-
Notifications
You must be signed in to change notification settings - Fork 4
ENG-1266: Bug: Component not loading on any page #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
@CodeRabbit ai full review |
|
@sid597: I'll conduct a full review of this PR. I can see this addresses a bug in 🧠 Learnings used✅ Actions performedFull review triggered. |
📝 WalkthroughWalkthrough
Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🧰 Additional context used📓 Path-based instructions (5)**/*.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/main.mdc)
Files:
apps/roam/**/*.{js,ts,tsx,jsx,json}📄 CodeRabbit inference engine (.cursor/rules/roam.mdc)
Files:
apps/roam/**/*.{ts,tsx,jsx,js,css,scss}📄 CodeRabbit inference engine (.cursor/rules/roam.mdc)
Files:
apps/roam/**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (.cursor/rules/roam.mdc)
Files:
apps/roam/**📄 CodeRabbit inference engine (.cursor/rules/roam.mdc)
Files:
🧠 Learnings (10)📓 Common learnings📚 Learning: 2025-12-07T20:54:20.007ZApplied to files:
📚 Learning: 2025-06-17T23:37:45.289ZApplied to files:
📚 Learning: 2025-06-17T23:37:45.289ZApplied to files:
📚 Learning: 2025-06-22T10:40:52.752ZApplied to files:
📚 Learning: 2025-11-05T21:57:14.909ZApplied to files:
📚 Learning: 2025-06-22T10:40:21.679ZApplied to files:
📚 Learning: 2025-06-25T22:56:17.522ZApplied to files:
📚 Learning: 2025-08-25T15:53:21.799ZApplied to files:
📚 Learning: 2025-11-25T00:52:41.934ZApplied to files:
🧬 Code graph analysis (1)apps/roam/src/utils/findDiscourseNode.ts (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…e related components to handle uid correctly. This improves type safety and prevents potential undefined errors.
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@sid597 I was working on another PR and also came across this. I went a different direction. |
|
#559 made |
|
|
||
| const nodes = getDiscourseNodes(); | ||
| const node = findDiscourseNode({ title, nodes }); | ||
| const uid = getPageUidByPageTitle(title); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing UID lets us use the findDiscourseNode cache, at the tradeoff of running a pull on every page. Queries on every page are not ideal, but this pull is pretty insignificant.

currently
findDiscourseNodeexists if we don't pass the uid which is wrong because bothuidandtitleare optionalSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.